Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934025Ab0GSOPI (ORCPT ); Mon, 19 Jul 2010 10:15:08 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:46841 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933742Ab0GSOPG (ORCPT ); Mon, 19 Jul 2010 10:15:06 -0400 Date: Mon, 19 Jul 2010 10:15:01 -0400 From: Christoph Hellwig To: Mel Gorman Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Christoph Hellwig , Wu Fengguang , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , Andrea Arcangeli Subject: Re: [PATCH 2/8] vmscan: tracing: Update trace event to track if page reclaim IO is for anon or file pages Message-ID: <20100719141501.GA12510@infradead.org> References: <1279545090-19169-1-git-send-email-mel@csn.ul.ie> <1279545090-19169-3-git-send-email-mel@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1279545090-19169-3-git-send-email-mel@csn.ul.ie> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 18 On Mon, Jul 19, 2010 at 02:11:24PM +0100, Mel Gorman wrote: > It is useful to distinguish between IO for anon and file pages. This > patch updates > vmscan-tracing-add-trace-event-when-a-page-is-written.patch to include > that information. The patches can be merged together. I think the trace would be nicer if you #define flags for both cases and then use __print_flags on them. That'll also make it more extensible in case we need to add more flags later. And a purely procedural question: This is supposed to get rolled into the original patch before it gets commited to a git tree, right? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/