Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934768Ab0GSOXv (ORCPT ); Mon, 19 Jul 2010 10:23:51 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:40300 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933836Ab0GSOXu (ORCPT ); Mon, 19 Jul 2010 10:23:50 -0400 Date: Mon, 19 Jul 2010 10:23:49 -0400 From: Christoph Hellwig To: Mel Gorman Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Christoph Hellwig , Wu Fengguang , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , Andrea Arcangeli Subject: Re: [PATCH 8/8] vmscan: Kick flusher threads to clean pages when reclaim is encountering dirty pages Message-ID: <20100719142349.GE12510@infradead.org> References: <1279545090-19169-1-git-send-email-mel@csn.ul.ie> <1279545090-19169-9-git-send-email-mel@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1279545090-19169-9-git-send-email-mel@csn.ul.ie> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 21 On Mon, Jul 19, 2010 at 02:11:30PM +0100, Mel Gorman wrote: > + /* > + * If reclaim is encountering dirty pages, it may be because > + * dirty pages are reaching the end of the LRU even though > + * the dirty_ratio may be satisified. In this case, wake > + * flusher threads to pro-actively clean some pages > + */ > + wakeup_flusher_threads(laptop_mode ? 0 : nr_dirty + nr_dirty / 2); > + Where is the laptop-mode magic coming from? And btw, at least currently wakeup_flusher_threads writes back nr_pages for each BDI, which might not be what you want. Then again probably no caller wants it, but I don't see an easy way to fix it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/