Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934872Ab0GSOYy (ORCPT ); Mon, 19 Jul 2010 10:24:54 -0400 Received: from gir.skynet.ie ([193.1.99.77]:41175 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934108Ab0GSOYx (ORCPT ); Mon, 19 Jul 2010 10:24:53 -0400 Date: Mon, 19 Jul 2010 15:24:36 +0100 From: Mel Gorman To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Wu Fengguang , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , Andrea Arcangeli Subject: Re: [PATCH 2/8] vmscan: tracing: Update trace event to track if page reclaim IO is for anon or file pages Message-ID: <20100719142436.GO13117@csn.ul.ie> References: <1279545090-19169-1-git-send-email-mel@csn.ul.ie> <1279545090-19169-3-git-send-email-mel@csn.ul.ie> <20100719141501.GA12510@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100719141501.GA12510@infradead.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1269 Lines: 35 On Mon, Jul 19, 2010 at 10:15:01AM -0400, Christoph Hellwig wrote: > On Mon, Jul 19, 2010 at 02:11:24PM +0100, Mel Gorman wrote: > > It is useful to distinguish between IO for anon and file pages. This > > patch updates > > vmscan-tracing-add-trace-event-when-a-page-is-written.patch to include > > that information. The patches can be merged together. > > I think the trace would be nicer if you #define flags for both > cases and then use __print_flags on them. That'll also make it more > extensible in case we need to add more flags later. > Not a bad idea, I'll check it out. Thanks. The first flags would be; RECLAIM_WB_ANON RECLAIM_WB_FILE Does anyone have problems with the naming? > And a purely procedural question: This is supposed to get rolled into > the original patch before it gets commited to a git tree, right? > That is my expectation. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/