Date: Mon, 19 Jul 2010 16:58:51 +0200
From: Christoph Hellwig <hch@lst.de>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Christoph Hellwig <hch@lst.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/3] [fs/sysv] V7: Add support for non-PDP11 v7 filesystems
Message-ID: <20100719145851.GD25279@lst.de>
References: <1279559802-19154-1-git-send-email-lkundrak@v3.sk> <1279559802-19154-2-git-send-email-lkundrak@v3.sk> <1279559802-19154-3-git-send-email-lkundrak@v3.sk> <1279559802-19154-4-git-send-email-lkundrak@v3.sk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1279559802-19154-4-git-send-email-lkundrak@v3.sk>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1082
Lines: 29

On Mon, Jul 19, 2010 at 07:16:42PM +0200, Lubomir Rintel wrote:
> A mount-time option was added that makes it possible to override the
> endianness and an attempt is made to autodetect it (which seems easy,
> given the disk addresses are 3-byte.
> 
> No attempt is made to detect big-endian filesystems -- were there any?
> Tested with PDP-11 v7 filesystems and PC-IX maintenance floppy.

Do you actually need the mount option?  We get away just fine with
it for sysv filesystems.  And if not I'd be consistent and accept the
options for both sysv and v7 filesystems.

> +	/* plausibility check on root inode: it is a directory,
> +	   with a nonzero size that is a multiple of 16 */
> +	if ((bh2 = sb_bread(sb, 2)) == NULL) {
> +		return 0;
> +	}

A little style nitpick, this should be:

	bh2 = sb_bread(sb, 2);
	if (!bh)
		return 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/