Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936332Ab0GSQAP (ORCPT ); Mon, 19 Jul 2010 12:00:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48444 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934478Ab0GSQAN (ORCPT ); Mon, 19 Jul 2010 12:00:13 -0400 Date: Mon, 19 Jul 2010 18:00:12 +0200 Message-ID: From: Takashi Iwai To: Giuliano Pochini Cc: Kulikov Vasiliy , kernel-janitors@vger.kernel.org, Jaroslav Kysela , Julia Lawall , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 11/15] pci: echoaudio: check kmalloc() result In-Reply-To: <20100716211650.4abb6387@Jay> References: <1279296943-25187-1-git-send-email-segooon@gmail.com> <20100716211650.4abb6387@Jay> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 41 At Fri, 16 Jul 2010 21:16:50 +0200, Giuliano Pochini wrote: > > On Fri, 16 Jul 2010 20:15:43 +0400 > Kulikov Vasiliy wrote: > > > If kmalloc() fails exit with -ENOMEM. > > > > Signed-off-by: Kulikov Vasiliy > > --- > > sound/pci/echoaudio/echoaudio.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c > > index 668a5ec..20763dd 100644 > > --- a/sound/pci/echoaudio/echoaudio.c > > +++ b/sound/pci/echoaudio/echoaudio.c > > @@ -2250,6 +2250,8 @@ static int snd_echo_resume(struct pci_dev *pci) > > DE_INIT(("resume start\n")); > > pci_restore_state(pci); > > commpage_bak = kmalloc(sizeof(struct echoaudio), GFP_KERNEL); > > + if (commpage_bak == NULL) > > + return -ENOMEM; > > commpage = chip->comm_page; > > memcpy(commpage_bak, commpage, sizeof(struct comm_page)); > > > > Yes, of course. Thank you. > > > Ack-by: Giuliano Pochini Applied now. Thanks. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/