Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965403Ab0GSSux (ORCPT ); Mon, 19 Jul 2010 14:50:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39619 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934942Ab0GSSuu (ORCPT ); Mon, 19 Jul 2010 14:50:50 -0400 Date: Mon, 19 Jul 2010 14:50:20 -0400 From: Jeff Layton To: Dave Kleikamp Cc: Kulikov Vasiliy , kernel-janitors@vger.kernel.org, Steve French , Tejun Heo , Joe Perches , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/15] fs: cifs: check kmalloc() result Message-ID: <20100719145020.205ece82@tlielax.poochiereds.net> In-Reply-To: <1279298130.26876.12.camel@shaggy-w500> References: <1279296925-25147-1-git-send-email-segooon@gmail.com> <1279298130.26876.12.camel@shaggy-w500> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 42 On Fri, 16 Jul 2010 11:35:30 -0500 Dave Kleikamp wrote: > On Fri, 2010-07-16 at 20:15 +0400, Kulikov Vasiliy wrote: > > If kmalloc() fails exit with -ENOMEM. > > Looks good to me. Add my ack if you want it. > > > Signed-off-by: Kulikov Vasiliy > > Acked-by: Dave Kleikamp > > > --- > > fs/cifs/readdir.c | 5 +++++ > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c > > index daf1753..d5e591f 100644 > > --- a/fs/cifs/readdir.c > > +++ b/fs/cifs/readdir.c > > @@ -847,6 +847,11 @@ int cifs_readdir(struct file *file, void *direntry, filldir_t filldir) > > end_of_smb = cifsFile->srch_inf.ntwrk_buf_start + max_len; > > > > tmp_buf = kmalloc(UNICODE_NAME_MAX, GFP_KERNEL); > > + if (tmp_buf == NULL) { > > + rc = -ENOMEM; > > + break; > > + } > > + > > for (i = 0; (i < num_to_fill) && (rc == 0); i++) { > > if (current_entry == NULL) { > > /* evaluate whether this case is an error */ > Looks good to me too. Acked-by: Jeff Layton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/