Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 24 Jun 2002 05:12:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 24 Jun 2002 05:11:59 -0400 Received: from www.scba.org.sz ([196.28.7.66]:65193 "HELO netfinity.realnet.co.sz") by vger.kernel.org with SMTP id ; Mon, 24 Jun 2002 05:11:57 -0400 Date: Mon, 24 Jun 2002 09:30:23 +0200 (SAST) From: Zwane Mwaikambo X-X-Sender: zwane@netfinity.realnet.co.sz To: Frank Davis Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] 2.5.24 : drivers/net/defxx.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 623 Lines: 26 On Sun, 23 Jun 2002, Frank Davis wrote: > - > + if(pci_set_dma_mask(pdev, 0xffffffff)) > + { > + printk(KERN_WARNING "defxx : No suitable DMA available\n"); > + } Minor nit, CodingStyle prefers this style; if (pci_set_dma_mask(pdev, 0xffffffff)) printk(KERN_WARNING "defxx : No suitable DMA available\n"); Thanks, Zwane Mwaikambo -- http://function.linuxpower.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/