DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns;
	h=mime-version:sender:in-reply-to:references:date:
	x-google-sender-auth:message-id:subject:from:to:cc:content-type:x-system-of-record;
	b=R8VNFtNRcL5Xh3kWx2hFTv1lO1/XdL6s2l4k46zSD6SsVYCR7jM9mG7GrwcbuKbRY
	aHDVpt6iN900CJ9rtJKBg==
MIME-Version: 1.0
In-Reply-To: <1279219395-12088-1-git-send-email-segooon@gmail.com>
References: <1279219395-12088-1-git-send-email-segooon@gmail.com>
Date: Tue, 20 Jul 2010 00:14:08 -0700
Message-ID: <AANLkTinFKH4Ed3UW3kMKdT5RJwmmE5n5k7nO01mB9xpO@mail.gmail.com>
Subject: Re: [PATCH 1/8] arm/mach-tegra: fix unsigned calcs
From: Colin Cross <ccross@android.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Erik Gilling <konkers@android.com>,
        Olof Johansson <olof@lixom.net>, Russell King <linux@arm.linux.org.uk>,
        linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 720
Lines: 18

On Thu, Jul 15, 2010 at 11:43 AM, Kulikov Vasiliy <segooon@gmail.com> wrote:
> divider_u71 is unsigned, so this check is buggy:
> if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0)
>
> If divider_u71 is 0 or 1 both checks are lying.
> So, it does not produce a buggy answer, but it is confusing.

Hi Kulikov,
Thanks for the patch.  This problem has been fixed in another patch in
the linux-tegra tree, I'll post it for review and update the
linux-next tree soon.

Colin Cross
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/