Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757241Ab0GTLNk (ORCPT ); Tue, 20 Jul 2010 07:13:40 -0400 Received: from smtp.nokia.com ([192.100.122.230]:43382 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755734Ab0GTLNj (ORCPT ); Tue, 20 Jul 2010 07:13:39 -0400 Subject: Re: [RFC][PATCH 12/16] writeback: add to bdi_list in the forker thread From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Christoph Hellwig Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20100718065851.GJ23811@infradead.org> References: <1279284312-2411-1-git-send-email-dedekind1@gmail.com> <1279284312-2411-13-git-send-email-dedekind1@gmail.com> <20100718065851.GJ23811@infradead.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 20 Jul 2010 14:07:04 +0300 Message-ID: <1279624024.16462.114.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 (2.30.2-1.fc13) Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 20 Jul 2010 11:13:29.0485 (UTC) FILETIME=[94FA13D0:01CB27FC] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 668 Lines: 17 On Sun, 2010-07-18 at 02:58 -0400, Christoph Hellwig wrote: > What about never removing a bdi from bdi_list? If we have the > correct checks for dirty_io and the task there's no need to > ever remove a life bdi from the list. Just add it in bdi_register > and remove it in bdi_unregister. Good idea, thanks, indeed I do not see why we need removing it. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/