Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761273Ab0GTMia (ORCPT ); Tue, 20 Jul 2010 08:38:30 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:5025 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758287Ab0GTMi1 (ORCPT ); Tue, 20 Jul 2010 08:38:27 -0400 Message-ID: <000801cb2808$72aef870$66f8800a@maildom.okisemi.com> From: "Masayuki Ohtake" To: "Arnd Bergmann" Cc: "Jean Delvare \(PC drivers, core\)" , "Ben Dooks \(embedded platforms\)" , , "LKML" , , "Wang, Yong Y" , , References: <4C204B0D.2030201@dsn.okisemi.com> <201007152135.00280.arnd@arndb.de> <000401cb27c7$ce732960$66f8800a@maildom.okisemi.com> <201007201127.57510.arnd@arndb.de> Subject: Re: [PATCH] I2C driver of Topcliff PCH Date: Tue, 20 Jul 2010 21:38:22 +0900 X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1983 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1983 X-Hosting-Pf: 0 X-NAI-Spam-Score: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1790 Lines: 47 Hi Arnd, > If you pass IRQF_SHARED, you can register any number of handlers > for the same IRQ number using different dev pointers. I will modify like above. Thanks, Ohtake. ----- Original Message ----- From: "Arnd Bergmann" To: "Masayuki Ohtake" Cc: "Jean Delvare (PC drivers, core)" ; "Ben Dooks (embedded platforms)" ; ; "LKML" ; ; "Wang, Yong Y" ; ; Sent: Tuesday, July 20, 2010 6:27 PM Subject: Re: [PATCH] I2C driver of Topcliff PCH > On Tuesday 20 July 2010, Masayuki Ohtake wrote: > > > > + > > > > + dev_dbg(&pdev->dev, > > > > + "i2c_add_adapter returns %d for channel-%d\n", ret, i); > > > > + pch_init(&adap_info->pch_data[i]); > > > > + dev_dbg(&pdev->dev, "pch_init invoked successfully\n"); > > > > + } > > > > + > > > > + ret = request_irq(pdev->irq, &pch_handler, IRQF_SHARED, > > > > + MODULE_NAME, adap_info); > > > > > > Similarly, you would create a new channel data structure for each channel here > > > and register it separately, and then request the interrupt with that > > > data structure as the info. > > > > With I2c multi-cahnnel IOH, IRQ number is in common. > > Thus, I think our PCH I2C driver can't be implemented like above. > > If you pass IRQF_SHARED, you can register any number of handlers > for the same IRQ number using different dev pointers. > > Arnd > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/