Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757019Ab0GTODH (ORCPT ); Tue, 20 Jul 2010 10:03:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24572 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752373Ab0GTODD (ORCPT ); Tue, 20 Jul 2010 10:03:03 -0400 From: Jeff Moyer To: Corrado Zoccolo Cc: Vivek Goyal , axboe@kernel.dk, Linux-Kernel Subject: Re: [PATCH 0/2] cfq-iosched: fixing RQ_NOIDLE handling. References: <20100713195650.GA21044@redhat.com> <20100713204236.GB21044@redhat.com> <20100719203109.GE32503@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 20 Jul 2010 10:02:45 -0400 In-Reply-To: <20100719203109.GE32503@redhat.com> (Vivek Goyal's message of "Mon, 19 Jul 2010 16:31:09 -0400") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 25 Vivek Goyal writes: > On Mon, Jul 19, 2010 at 12:08:23PM -0400, Jeff Moyer wrote: >> So, I'm still in favor of Corrado's approach. Are there any remaining >> dissenting opinions on this? > > Nope. I am fine with moving all WRITE_SYNC with RQ_NOIDLE to sync-noidle > tree and also marking jbd writes as WRITE_SYNC. By bringing dependent > threads on single service tree, we don't have to worry about slice > yielding. > > Acked-by: Vivek Goyal Corrado, would you mind reposting the patches and adding: Reviewed-by: Jeff Moyer Tested-by: Jeff Moyer Thanks! Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/