Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932417Ab0GTPdH (ORCPT ); Tue, 20 Jul 2010 11:33:07 -0400 Received: from cantor.suse.de ([195.135.220.2]:34582 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760904Ab0GTPdD (ORCPT ); Tue, 20 Jul 2010 11:33:03 -0400 Date: Tue, 20 Jul 2010 17:33:01 +0200 (CEST) From: Jiri Kosina To: Kulikov Vasiliy Cc: Kernel Janitors , Samuel Ortiz , "David S. Miller" , Stephen Hemminger , Joe Perches , Eric Dumazet , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/19] drivers/net/irda: use for_each_pci_dev() In-Reply-To: <1278173056-11779-1-git-send-email-segooon@gmail.com> Message-ID: References: <1278173056-11779-1-git-send-email-segooon@gmail.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 46 On Sat, 3 Jul 2010, Kulikov Vasiliy wrote: > Use for_each_pci_dev() to simplify the code. > > Signed-off-by: Kulikov Vasiliy > --- > drivers/net/irda/smsc-ircc2.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/irda/smsc-ircc2.c b/drivers/net/irda/smsc-ircc2.c > index d67e484..850ca1c 100644 > --- a/drivers/net/irda/smsc-ircc2.c > +++ b/drivers/net/irda/smsc-ircc2.c > @@ -2848,9 +2848,7 @@ static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg, > unsigned short ss_device = 0x0000; > int ret = 0; > > - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev); > - > - while (dev != NULL) { > + for_each_pci_dev(dev) { > struct smsc_ircc_subsystem_configuration *conf; > > /* > @@ -2899,7 +2897,6 @@ static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg, > ret = -ENODEV; > } > } > - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev); > } > > return ret; Doesn't seem to hit linux-next as of today. Dave, are you going to merge it? Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/