Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932488Ab0GTPny (ORCPT ); Tue, 20 Jul 2010 11:43:54 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:41707 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392Ab0GTPnx convert rfc822-to-8bit (ORCPT ); Tue, 20 Jul 2010 11:43:53 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed; delsp=yes Date: Tue, 20 Jul 2010 17:45:13 +0200 From: =?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?= Subject: Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number In-reply-to: <289287.8629.qm@web180303.mail.gq1.yahoo.com> To: Alan Stern , David Brownell Cc: Greg KH , Kyungmin Park , Marek Szyprowski , Kernel development list , Dries Van Puymbroeck Message-id: Organization: Samsung Electronics Content-transfer-encoding: 8BIT User-Agent: Opera Mail/10.60 (Linux) References: <289287.8629.qm@web180303.mail.gq1.yahoo.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 41 >>> Plus, you seem to be overlooking the basic need >>> (for userspace) to manage these IDs so they're >>> properly unique. Two gadgets should never end >>> up using the same serial number > --- On Tue, 7/20/10, Michał Nazarewicz wrote: >> I'm not overlooking that. I simply consider that a separate >> issue. Driver should provide some kind of default. On Tue, 20 Jul 2010 17:01:37 +0200, David Brownell wrote: > It can't do that and guarantee uniqueness. I never claimed otherwise. > Your concept is (still/again) broken. I don't buy that. The driver works better with a non-unique serial number then without any. As such, a default serial number should, in my opinion, be provided. >> (just like File Storage Gadget) and the fact that user space >> should override it is another matter in my opinion. > The value must come from userspace in the first > place, else it can't be correctly managed!! I would say it *should* come from userspace but if userspace fails to provide one *something* is better then *nothing*. I see how gadgets should print a warning if serial is not provided from user space but other then that I still think gadget should provide some value. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/