Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762023Ab0GUBpe (ORCPT ); Tue, 20 Jul 2010 21:45:34 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42841 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761828Ab0GUBpc (ORCPT ); Tue, 20 Jul 2010 21:45:32 -0400 Date: Tue, 20 Jul 2010 18:45:48 -0700 (PDT) Message-Id: <20100720.184548.250802682.davem@davemloft.net> To: mikpe@it.uu.se Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-s390@vger.kernel.org, linux-alpha@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH] math-emu: correct test for downshifting fraction in _FP_FROM_INT() From: David Miller In-Reply-To: <19524.51858.992299.119315@pilspetsen.it.uu.se> References: <19524.51858.992299.119315@pilspetsen.it.uu.se> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 23 From: Mikael Pettersson Date: Mon, 19 Jul 2010 23:58:42 +0200 > The kernel's math-emu code contains a macro _FP_FROM_INT() which is > used to convert an integer to a raw normalized floating-point value. > It does this basically in three steps: ... > The fix is simple: the exponent comparison used to determine if the > fraction should be downshifted must be "<=" not "<". > > I'm sending a kernel module to test this as a reply to this message. > There are also SPARC user-space test cases in the GCC bug entry. > > Signed-off-by: Mikael Pettersson Applied and I'll make sure this gets into -stable too. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/