Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757168Ab0GUN2U (ORCPT ); Wed, 21 Jul 2010 09:28:20 -0400 Received: from borg.medozas.de ([188.40.89.202]:58642 "EHLO borg.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752977Ab0GUN2S (ORCPT ); Wed, 21 Jul 2010 09:28:18 -0400 Date: Wed, 21 Jul 2010 15:28:16 +0200 (CEST) From: Jan Engelhardt To: Simon Horman cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org, Malcolm Turnbull , Wensong Zhang , Julius Volz , Patrick McHardy , "David S. Miller" , Hannes Eder Subject: Re: [patch v2.6 4/4] libxt_ipvs: user-space lib for netfilter matcher xt_ipvs In-Reply-To: <20100721132159.GN6418@verge.net.au> Message-ID: References: <20100711090342.035149543@vergenet.net> <20100711090500.421568837@vergenet.net> <20100721012146.GC22966@verge.net.au> <20100721132159.GN6418@verge.net.au> User-Agent: Alpine 2.01 (LSU 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 30 On Wednesday 2010-07-21 15:21, Simon Horman wrote: >> On Wednesday 2010-07-21 03:21, Simon Horman wrote: >> >> + >> >> +#define XT_IPVS_IPVS_PROPERTY (1 << 0) /* all other options imply this one */ >> >> +#define XT_IPVS_PROTO (1 << 1) >> >> +#define XT_IPVS_VADDR (1 << 2) >> >> +#define XT_IPVS_VPORT (1 << 3) >> >> +#define XT_IPVS_DIR (1 << 4) >> >> +#define XT_IPVS_METHOD (1 << 5) >> >> +#define XT_IPVS_VPORTCTL (1 << 6) >> >> +#define XT_IPVS_MASK ((1 << 7) - 1) >> >> +#define XT_IPVS_ONCE_MASK (XT_IPVS_MASK & ~XT_IPVS_IPVS_PROPERTY) >> >> Can't these just be an enum? > >More than one option can be used at once - they form a mini bitmap - >so no, I don't think we can use an enum. An enum does not dictate that you cannot combine values of it with itself. enum { A = 1 << 0, B = 1 << 0, }; unsigned int flags = A | B; is perfectly fine, which is what other modules do. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/