Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758722Ab0GUPGs (ORCPT ); Wed, 21 Jul 2010 11:06:48 -0400 Received: from gir.skynet.ie ([193.1.99.77]:42156 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047Ab0GUPGq (ORCPT ); Wed, 21 Jul 2010 11:06:46 -0400 Date: Wed, 21 Jul 2010 16:06:29 +0100 From: Mel Gorman To: Johannes Weiner Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Christoph Hellwig , Wu Fengguang , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , Andrea Arcangeli Subject: Re: [PATCH 4/8] vmscan: Do not writeback filesystem pages in direct reclaim Message-ID: <20100721150629.GB13117@csn.ul.ie> References: <1279545090-19169-5-git-send-email-mel@csn.ul.ie> <20100719221420.GA16031@cmpxchg.org> <20100720134555.GU13117@csn.ul.ie> <20100720220218.GE16031@cmpxchg.org> <20100721115250.GX13117@csn.ul.ie> <20100721130435.GH16031@cmpxchg.org> <20100721133857.GY13117@csn.ul.ie> <20100721142819.GA10480@cmpxchg.org> <20100721143118.GA13117@csn.ul.ie> <20100721143955.GB10480@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100721143955.GB10480@cmpxchg.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 38 On Wed, Jul 21, 2010 at 04:39:56PM +0200, Johannes Weiner wrote: > On Wed, Jul 21, 2010 at 03:31:19PM +0100, Mel Gorman wrote: > > On Wed, Jul 21, 2010 at 04:28:44PM +0200, Johannes Weiner wrote: > > > On Wed, Jul 21, 2010 at 02:38:57PM +0100, Mel Gorman wrote: > > > > @@ -858,7 +872,7 @@ keep: > > > > > > > > free_page_list(&free_pages); > > > > > > > > - list_splice(&ret_pages, page_list); > > > > > > This will lose all retry pages forever, I think. > > > > > > > Above this is > > > > while (!list_empty(page_list)) { > > ... > > } > > > > page_list should be empty and keep_locked is putting the pages on ret_pages > > already so I think it's ok. > > But ret_pages is function-local. Putting them back on the then-empty > page_list is to give them back to the caller, otherwise they are lost > in a dead stack slot. > Bah, you're right, it is repaired now. /me slaps self. Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/