Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758808Ab0GUS6P (ORCPT ); Wed, 21 Jul 2010 14:58:15 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:48962 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774Ab0GUS6O (ORCPT ); Wed, 21 Jul 2010 14:58:14 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6050"; a="48039564" Subject: Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added From: Daniel Walker To: =?UTF-8?Q?Micha=C5=82?= Nazarewicz Cc: linux-mm@kvack.org, Marek Szyprowski , Pawel Osciak , Xiaolin Zhang , Hiremath Vaibhav , Robert Fekete , Marcus Lorentzon , linux-kernel@vger.kernel.org, Kyungmin Park , linux-arm-msm@vger.kernel.org In-Reply-To: References: <1279649724.26765.23.camel@c-dwalke-linux.qualcomm.com> <1279654698.26765.31.camel@c-dwalke-linux.qualcomm.com> <1279733750.31376.14.camel@c-dwalke-linux.qualcomm.com> <1279736348.31376.20.camel@c-dwalke-linux.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 21 Jul 2010 11:58:08 -0700 Message-ID: <1279738688.31376.24.camel@c-dwalke-linux.qualcomm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2063 Lines: 44 On Wed, 2010-07-21 at 20:38 +0200, Michał Nazarewicz wrote: > > On Wed, 2010-07-21 at 20:11 +0200, Michał Nazarewicz wrote: > >> Not really. This will probably be used mostly on embedded systems > >> where users don't have much to say as far as hardware included on the > >> platform is concerned, etc. Once a phone, tablet, etc. is released > >> users will have little need for customising those strings. > > On Wed, 21 Jul 2010 20:19:08 +0200, Daniel Walker wrote: > > You can't assume that user won't want to reflash their own kernel on the > > device. Your assuming way too much. > > If user is clever enough to reflash a phone she will find the strings > easy especially that they are provided from: (i) bootloader which is > even less likely to be reflashed and if someone do reflash bootloader > she is a guru who'd know how to make the strings; or (ii) platform > defaults which will be available with the rest of the source code > for the platform. Your, again, assuming all sorts of stuff .. On my phone for example it is very easy to reflash, personally, I think most devices will be like that in the future. so you don't _need_ to be clever to reflash the device. > > If you assume they do want their own kernel then they would need this > > string from someplace. If your right and this wouldn't need to change, > > why bother allowing it to be configured at all ? > > Imagine a developer who needs to recompile the kernel and reflash the > device each time she wants to change the configuration... Command line > arguments seems a better option for development. So make it a default off debug configuration option .. Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/