Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755417Ab0GVFga (ORCPT ); Thu, 22 Jul 2010 01:36:30 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:43254 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405Ab0GVFg3 (ORCPT ); Thu, 22 Jul 2010 01:36:29 -0400 Date: Thu, 22 Jul 2010 11:06:24 +0530 From: Balbir Singh To: KOSAKI Motohiro Cc: Mel Gorman , LKML , linux-mm , Andrew Morton , KAMEZAWA Hiroyuki , Nishimura Daisuke Subject: Re: [PATCH 3/7] memcg: nid and zid can be calculated from zone Message-ID: <20100722053624.GN14369@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20100716191418.7372.A69D9226@jp.fujitsu.com> <20100716105648.GG13117@csn.ul.ie> <20100721223349.870D.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20100721223349.870D.A69D9226@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2502 Lines: 71 * KOSAKI Motohiro [2010-07-21 22:33:56]: > > > +static inline int zone_nid(struct zone *zone) > > > +{ > > > + return zone->zone_pgdat->node_id; > > > +} > > > + > > > > hmm, adding a helper and not converting the existing users of > > zone->zone_pgdat may be a little confusing particularly as both types of > > usage would exist in the same file e.g. in mem_cgroup_zone_nr_pages. > > I see. here is incrementa patch. > > Thanks > > From 62cf765251af257c98fc92a58215d101d200e7ef Mon Sep 17 00:00:00 2001 > From: KOSAKI Motohiro > Date: Tue, 20 Jul 2010 11:30:14 +0900 > Subject: [PATCH] memcg: convert to zone_nid() from bare zone->zone_pgdat->node_id > > Now, we have zone_nid(). this patch convert all existing users of > zone->zone_pgdat. > > Signed-off-by: KOSAKI Motohiro > --- > mm/memcontrol.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 82e191f..3d5b645 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -951,7 +951,7 @@ unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg, > struct zone *zone, > enum lru_list lru) > { > - int nid = zone->zone_pgdat->node_id; > + int nid = zone_nid(zone); > int zid = zone_idx(zone); > struct mem_cgroup_per_zone *mz = mem_cgroup_zoneinfo(memcg, nid, zid); > > @@ -961,7 +961,7 @@ unsigned long mem_cgroup_zone_nr_pages(struct mem_cgroup *memcg, > struct zone_reclaim_stat *mem_cgroup_get_reclaim_stat(struct mem_cgroup *memcg, > struct zone *zone) > { > - int nid = zone->zone_pgdat->node_id; > + int nid = zone_nid(zone); > int zid = zone_idx(zone); > struct mem_cgroup_per_zone *mz = mem_cgroup_zoneinfo(memcg, nid, zid); > > @@ -1006,7 +1006,7 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, > LIST_HEAD(pc_list); > struct list_head *src; > struct page_cgroup *pc, *tmp; > - int nid = z->zone_pgdat->node_id; > + int nid = zone_nid(z); > int zid = zone_idx(z); > struct mem_cgroup_per_zone *mz; > int lru = LRU_FILE * file + active; Acked-by: Balbir Singh -- Three Cheers, Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/