To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, nhorman@redhat.com,
        akpm@linux-foundation.org
Subject: Re: [Patch] kexec: increase max of kexec segments and use dynamic allocation
References: <20100722061810.5659.87609.sendpatchset@localhost.localdomain>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Wed, 21 Jul 2010 23:28:45 -0700
In-Reply-To: <20100722061810.5659.87609.sendpatchset@localhost.localdomain> (Amerigo Wang's message of "Thu\, 22 Jul 2010 02\:13\:55 -0400")
Message-ID: <m1wrso2foi.fsf@fess.ebiederm.org>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 797
Lines: 21

Amerigo Wang <amwang@redhat.com> writes:

> Currently KEXEC_SEGMENT_MAX is only 16 which is too small for machine with
> many memory ranges. Increase this hard limit to 1024 which is reasonably large,
> and change ->segment from a static array to a dynamically allocated memory.

???

This should be about segments in the executable being loaded.  What
executable has one segment for each range of physical memory?

Not that generalizing this is a bad idea but with a comment that
seems entirely wrong I am wondering what the problem really is.

Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/