Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756055Ab0GVJWI (ORCPT ); Thu, 22 Jul 2010 05:22:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:12382 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754037Ab0GVJWC (ORCPT ); Thu, 22 Jul 2010 05:22:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.55,242,1278313200"; d="scan'208";a="640689764" Date: Thu, 22 Jul 2010 17:21:55 +0800 From: Wu Fengguang To: Mel Gorman Cc: Christoph Hellwig , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , Andrea Arcangeli , Minchan Kim Subject: Re: [PATCH 7/8] writeback: sync old inodes first in background writeback Message-ID: <20100722092155.GA28425@localhost> References: <1279545090-19169-1-git-send-email-mel@csn.ul.ie> <1279545090-19169-8-git-send-email-mel@csn.ul.ie> <20100719142145.GD12510@infradead.org> <20100719144046.GR13117@csn.ul.ie> <20100722085210.GA26714@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100722085210.GA26714@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2540 Lines: 67 > I guess this new patch is more problem oriented and acceptable: > > --- linux-next.orig/mm/vmscan.c 2010-07-22 16:36:58.000000000 +0800 > +++ linux-next/mm/vmscan.c 2010-07-22 16:39:57.000000000 +0800 > @@ -1217,7 +1217,8 @@ static unsigned long shrink_inactive_lis > count_vm_events(PGDEACTIVATE, nr_active); > > nr_freed += shrink_page_list(&page_list, sc, > - PAGEOUT_IO_SYNC); > + priority < DEF_PRIORITY / 3 ? > + PAGEOUT_IO_SYNC : PAGEOUT_IO_ASYNC); > } > > nr_reclaimed += nr_freed; This one looks better: --- vmscan: raise the bar to PAGEOUT_IO_SYNC stalls Fix "system goes totally unresponsive with many dirty/writeback pages" problem: http://lkml.org/lkml/2010/4/4/86 The root cause is, wait_on_page_writeback() is called too early in the direct reclaim path, which blocks many random/unrelated processes when some slow (USB stick) writeback is on the way. A simple dd can easily create a big range of dirty pages in the LRU list. Therefore priority can easily go below (DEF_PRIORITY - 2) in a typical desktop, which triggers the lumpy reclaim mode and hence wait_on_page_writeback(). In Andreas' case, 512MB/1024 = 512KB, this is way too low comparing to the 22MB writeback and 190MB dirty pages. There can easily be a continuous range of 512KB dirty/writeback pages in the LRU, which will trigger the wait logic. To make it worse, when there are 50MB writeback pages and USB 1.1 is writing them in 1MB/s, wait_on_page_writeback() may stuck for up to 50 seconds. So only enter sync write&wait when priority goes below DEF_PRIORITY/3, or 6.25% LRU. As the default dirty throttle ratio is 20%, sync write&wait will hardly be triggered by pure dirty pages. Signed-off-by: Wu Fengguang --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next.orig/mm/vmscan.c 2010-07-22 16:36:58.000000000 +0800 +++ linux-next/mm/vmscan.c 2010-07-22 17:03:47.000000000 +0800 @@ -1206,7 +1206,7 @@ static unsigned long shrink_inactive_lis * but that should be acceptable to the caller */ if (nr_freed < nr_taken && !current_is_kswapd() && - sc->lumpy_reclaim_mode) { + sc->lumpy_reclaim_mode && priority < DEF_PRIORITY / 3) { congestion_wait(BLK_RW_ASYNC, HZ/10); /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/