Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755417Ab0GVLsH (ORCPT ); Thu, 22 Jul 2010 07:48:07 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:56456 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753185Ab0GVLsD convert rfc822-to-8bit (ORCPT ); Thu, 22 Jul 2010 07:48:03 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed; delsp=yes Date: Thu, 22 Jul 2010 13:49:26 +0200 From: =?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?= Subject: Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added In-reply-to: <20100722191658V.fujita.tomonori@lab.ntt.co.jp> To: FUJITA Tomonori Cc: m.szyprowski@samsung.com, corbet@lwn.net, linux-mm@kvack.org, p.osciak@samsung.com, xiaolin.zhang@intel.com, hvaibhav@ti.com, robert.fekete@stericsson.com, marcus.xm.lorentzon@stericsson.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com Message-id: Organization: Samsung Electronics Content-transfer-encoding: 8BIT User-Agent: Opera Mail/10.60 (Linux) References: <000001cb296f$6eba8fa0$4c2faee0$%szyprowski@samsung.com> <20100722183432U.fujita.tomonori@lab.ntt.co.jp> <20100722191658V.fujita.tomonori@lab.ntt.co.jp> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2435 Lines: 55 > On Thu, 22 Jul 2010 11:50:58 +0200 > **UNKNOWN CHARSET** wrote: >> So you are talking about moving complexity from the CMA core to the drivers. On Thu, 22 Jul 2010 12:17:42 +0200, FUJITA Tomonori wrote: > I don't think that adjusting some drivers about how they use memory is > so complicated. Just about how much and exclusive or share. I don't believe it is that simple. If shared then with what? What if foo-dev can share with bar-dev and baz-dev can share with qux-dev? Also, even if its 10 lines of code in each driver isn't it worth removing from the driver and not let it worry about it? The configuration needs to be specified one way of another, my approach with CMA was to centralise it so that drivers do not need to worry about it. > And adjusting drivers in embedded systems is necessary anyway. It should not be... > It's too complicated feature that isn't useful for the majority. Please consider what I've written in discussion with Mark Brown. >> Lost you there... If something does not make sense on your system you >> don't configure CMA to do that. That's one of the points of CMA. What >> does not make sense on your platform may make perfect sense on some >> other system, with some other drivers maybe. > What's your point? The majority of features (e.g. scsi, ata, whatever) > works in that way. They are useful on some and not on some. My point is, that you can configure CMA the way you want... > Are you saying, "my system needs this feature. You can disable it if > you don't need it. so let's merge it. it doesn't break your system."? No. I'm saying many of the embedded systems without IO MMU need to be able to allocate contiguous memory chunks. I'm also saying there is at least one system where some non-trivial configuration is needed and adding configuration handling to CMA is not as big of a cost as one may imagine. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/