Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759548Ab0GVOOg (ORCPT ); Thu, 22 Jul 2010 10:14:36 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:49115 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1759439Ab0GVOOe (ORCPT ); Thu, 22 Jul 2010 10:14:34 -0400 Date: Thu, 22 Jul 2010 10:14:32 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Michal Nazarewicz cc: linux-usb@vger.kernel.org, Kyungmin Park , Marek Szyprowski , David Brownell , Greg KH , , Yann Cantin Subject: Re: [PATCHv4 5/5] USB: gadget: file_storage: serial parameter even if not test mode In-Reply-To: <709d887b2249e9651060729eb62b29a1d3edc256.1279794290.git.m.nazarewicz@samsung.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 31 On Thu, 22 Jul 2010, Michal Nazarewicz wrote: > Moved the serial parameter handling code out of "#ifdef > CONFIG_USB_FILE_STORAGE_TEST". > > This modifies Yann Cantin's commit "USB: Add a serial number > parameter to g_file_storage" module as per Alan Stern's request. > > Signed-off-by: Michal Nazarewicz > Signed-off-by: Kyungmin Park > Cc: Alan Stern > Cc: Yann Cantin > --- > Alan Stern wrote: > > I have only one objection to this [Yann Cantin's] patch: The new > > parameter's name should be "serial", not "serial_parm". > > Alan Stern wrote: > > The serial number parameter is important enough that it should be > > available even on builds without CONFIG_USB_FILE_STORAGE_TEST. > > drivers/usb/gadget/file_storage.c | 20 +++++++++++--------- > 1 files changed, 11 insertions(+), 9 deletions(-) Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/