Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759539Ab0GVOWl (ORCPT ); Thu, 22 Jul 2010 10:22:41 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:33675 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1758866Ab0GVOWi (ORCPT ); Thu, 22 Jul 2010 10:22:38 -0400 Date: Thu, 22 Jul 2010 10:22:37 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Michal Nazarewicz cc: linux-usb@vger.kernel.org, Adam Kropelin , Xiaofan Chen , Subject: Re: [PATCH] USB: core: Choose configuration with lowest bConfigurationValue In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 22 On Thu, 22 Jul 2010, Michal Nazarewicz wrote: > This patch removes code from usb_choose_configuration() > responsible for ignoring the first USB device configuration if > its first interface is RNDIS. Instead, > usb_choose_configuration() chooses configuration with lowest > bConfigurationValue. Linux' Ethernet gadget uses a lower > bConfigurationValue for the second configuration which is > a CDC configuration so this code should choose configuration > that suits Linux better. I don't like this idea. Choosing configs is a sensitive topic, since it is highly visible to users. It should be changed minimally, if at all. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/