Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 25 Jun 2002 10:50:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 25 Jun 2002 10:50:44 -0400 Received: from realimage.realnet.co.sz ([196.28.7.3]:64727 "HELO netfinity.realnet.co.sz") by vger.kernel.org with SMTP id ; Tue, 25 Jun 2002 10:50:43 -0400 Date: Tue, 25 Jun 2002 16:21:07 +0200 (SAST) From: Zwane Mwaikambo X-X-Sender: zwane@netfinity.realnet.co.sz To: OGAWA Hirofumi Cc: Martin Dalecki , Jens Axboe , Linux Kernel Subject: Re: [PATCH][RFC] IDE locking #2 In-Reply-To: <874rfrlibx.fsf@devron.myhome.or.jp> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 26 On Tue, 25 Jun 2002, OGAWA Hirofumi wrote: > > + BUG_ON(!spin_is_locked(ch->lock)); > > spin_is_locked() returns 0 always on the UP system. > Instead, the following macro may be useful. > > #ifdef CONFIG_SMP > #define assert_spin_is_locked(lock) BUG_ON(!spin_is_locked(lock)) > #else > #define assert_spin_is_locked(lock) do {} while(0) > #endif Oh my =) thanks i'll change that. Cheers, Zwane -- http://function.linuxpower.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/