Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756721Ab0GVTLl (ORCPT ); Thu, 22 Jul 2010 15:11:41 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:42004 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755837Ab0GVTLk (ORCPT ); Thu, 22 Jul 2010 15:11:40 -0400 Date: Thu, 22 Jul 2010 16:11:32 -0300 From: Arnaldo Carvalho de Melo To: Gleb Natapov Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, peterz@infradead.org, paulus@samba.org Subject: Re: [PATCH v2] Re: perf annotate segfaults when source code has goto label that looks like hex number Message-ID: <20100722191132.GG17631@ghostprotocols.net> References: <20100722072044.GD27177@redhat.com> <20100722143345.GC17631@ghostprotocols.net> <20100722163851.GA10307@redhat.com> <20100722164711.GD17631@ghostprotocols.net> <20100722165222.GE17631@ghostprotocols.net> <20100722170541.GF17631@ghostprotocols.net> <20100722180538.GB10307@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100722180538.GB10307@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 36 Em Thu, Jul 22, 2010 at 09:05:38PM +0300, Gleb Natapov escreveu: > On Thu, Jul 22, 2010 at 02:05:42PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jul 22, 2010 at 01:52:22PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Jul 22, 2010 at 01:47:11PM -0300, Arnaldo Carvalho de Melo escreveu: > > > It could be a comment of play code, like: > > > while(1) { > > > if (++i == 10000000) > > > goto add; > > > } > > > add: return 0; > > What about this one? > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > > @@ -976,13 +976,15 @@ static int hist_entry__parse_objdump_line(struct hist_entry *self, FILE *file, > > if (line_ip != -1) { > > u64 start = map__rip_2objdump(self->ms.map, sym->start); > > offset = line_ip - start; > > + if (offset < 0 || (u64)line_ip > sym->end) > > + offset = -1; > This part is good idea anyway. Even if label will be interpreted as ip > perf at least will not crash. It may miss-report something if check will > accidentally succeed though. Yeah, we can possibly find a label which is a valid hex number and that falls inside the address range, but with what we have in objdump this seems to be the best we can have, I'll commit this. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/