Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347Ab0GVXzR (ORCPT ); Thu, 22 Jul 2010 19:55:17 -0400 Received: from kroah.org ([198.145.64.141]:54209 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753527Ab0GVXzP (ORCPT ); Thu, 22 Jul 2010 19:55:15 -0400 Date: Thu, 22 Jul 2010 16:46:30 -0700 From: Greg KH To: Michal Nazarewicz Cc: linux-usb@vger.kernel.org, Kyungmin Park , Marek Szyprowski , David Brownell , Alan Stern , linux-kernel@vger.kernel.org, Dries Van Puymbroeck , stable Subject: Re: [PATCHv4 1/5] USB: gadget: composite: Better string override handling Message-ID: <20100722234630.GA1352@kroah.com> References: <89baa7d196b5e1d8427c90a78f2aa0cda4331d7a.1279794289.git.m.nazarewicz@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89baa7d196b5e1d8427c90a78f2aa0cda4331d7a.1279794289.git.m.nazarewicz@samsung.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 26 On Thu, Jul 22, 2010 at 02:16:33PM +0200, Michal Nazarewicz wrote: > The iManufatcurer, iProduct and iSerialNumber composite module > parameters are only used when the gadget driver registers > strings for manufacturer, product and serial number. If the > gadget never bothered to set corresponding fields in USB > device descriptors those module parameters are ignored. > > This patch makes the parameters even if the strings ID have > not been assigned. It also changes the way IDs are > overridden -- what IDs are overridden is now saved in > usb_composite_dev structure -- which makes it unnecessary to > modify the string tables the way previous code did. David, do these look better? And they are not -stable material, no matter what, sorry, so you can stop copying stable@kernel.org on them. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/