Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139Ab0GWHdT (ORCPT ); Fri, 23 Jul 2010 03:33:19 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:37046 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620Ab0GWHdR (ORCPT ); Fri, 23 Jul 2010 03:33:17 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: balbir@linux.vnet.ibm.com Subject: Re: [PATCH 1/7] memcg: sc.nr_to_reclaim should be initialized Cc: kosaki.motohiro@jp.fujitsu.com, LKML , linux-mm , Andrew Morton , Mel Gorman , KAMEZAWA Hiroyuki , Nishimura Daisuke In-Reply-To: <20100722053113.GL14369@balbir.in.ibm.com> References: <20100716191256.736C.A69D9226@jp.fujitsu.com> <20100722053113.GL14369@balbir.in.ibm.com> Message-Id: <20100723154638.88C8.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Fri, 23 Jul 2010 16:33:13 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1817 Lines: 55 > * KOSAKI Motohiro [2010-07-16 19:13:31]: > > > Currently, mem_cgroup_shrink_node_zone() initialize sc.nr_to_reclaim as 0. > > It mean shrink_zone() only scan 32 pages and immediately return even if > > it doesn't reclaim any pages. > > > > This patch fixes it. > > > > Signed-off-by: KOSAKI Motohiro > > --- > > mm/vmscan.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 1691ad0..bd1d035 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -1932,6 +1932,7 @@ unsigned long mem_cgroup_shrink_node_zone(struct mem_cgroup *mem, > > struct zone *zone, int nid) > > { > > struct scan_control sc = { > > + .nr_to_reclaim = SWAP_CLUSTER_MAX, > > .may_writepage = !laptop_mode, > > .may_unmap = 1, > > .may_swap = !noswap, > > Could you please do some additional testing on > > 1. How far does this push pages (in terms of when limit is hit)? 32 pages per mem_cgroup_shrink_node_zone(). That said, the algorithm is here. 1. call mem_cgroup_largest_soft_limit_node() calculate largest cgroup 2. call mem_cgroup_shrink_node_zone() and shrink 32 pages 3. goto 1 if limit is still exceed. If it's not your intention, can you please your intended algorithm? > 2. Did you hit a problem with the current setting or is it a review > fix? I've found this by review. and my patch works fine on my test environment. Of cource, if you do _not_ run the code on heavy pressure, your original code works too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/