DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=oAjO0lVGX+O2eRE65mb75Hgth+TSk8h3UUuljFB5qdqzPuVa+2z/eYk6Bi8jptqcFj
         SWgBENEXNEKHxrGJhTOp9cpHoiuOq7amDvdOY3bmOzuUZ/5Gh8ZyS4OhDikbDxqXPjGC
         lJ2/EeucqJ7NMx3tNRMSFuCsVXOoCKTL6B4DE=
MIME-Version: 1.0
In-Reply-To: <4C455597.2020200@renesas.com>
References: <4C455597.2020200@renesas.com>
Date: Fri, 23 Jul 2010 20:10:09 +0900
Message-ID: <AANLkTimSk_YOs7shfthCKgAVHcHyyJLh+P5qHkw_i7pH@mail.gmail.com>
Subject: Re: [PATCH] tmio_mmc: Make ack_mmc_irqs() write-only
From: Magnus Damm <magnus.damm@gmail.com>
To: Yusuke Goda <yusuke.goda.sx@renesas.com>
Cc: ian@mnementh.co.uk, damm@opensource.se, sameo@linux.intel.com,
        Paul Mundt <lethal@linux-sh.org>, g.liakhovetski@gmx.de,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 888
Lines: 19

2010/7/20 Yusuke Goda <yusuke.goda.sx@renesas.com>:
> This patch updates ack_mmc_irqs() to acknowledge using write instead
> of read-modify-write. Without this fix the old read-modify-write
> implementation may acknowledge interrupt sources by mistake. The
> driver may if so lock-up waiting forever for an interrupt that will
> never come. Observed with the TMIO_STAT_RXRDY bit together with CMD53
> on AR6002 and BCM4318 SDIO cards in polled mode.
>
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>

Simple testing with a BCM4318 card and a MMC card on sh7372 and SDHI
shows no problems.

Acked-by: Magnus Damm <damm@opensource.se>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/