Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758299Ab0GWQ2F (ORCPT ); Fri, 23 Jul 2010 12:28:05 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:60251 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757485Ab0GWQ2B (ORCPT ); Fri, 23 Jul 2010 12:28:01 -0400 Date: Fri, 23 Jul 2010 12:28:00 -0400 From: Christoph Hellwig To: Artem Bityutskiy Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 12/14] writeback: optimize periodic bdi thread wakeups Message-ID: <20100723162800.GB29633@infradead.org> References: <1279897554-1526-1-git-send-email-dedekind1@gmail.com> <1279897554-1526-13-git-send-email-dedekind1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1279897554-1526-13-git-send-email-dedekind1@gmail.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 481 Lines: 10 I haven't reviewed this in detail, but what ensures the timer is synchronously removed when the forker goes away? I don't see a del_timer_sync call anywhere. For now it might be easier to just skip this patch and leave it for later. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/