Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759886Ab0GWQ2Q (ORCPT ); Fri, 23 Jul 2010 12:28:16 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:60573 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758835Ab0GWQ2M (ORCPT ); Fri, 23 Jul 2010 12:28:12 -0400 Date: Fri, 23 Jul 2010 12:28:11 -0400 From: Christoph Hellwig To: Artem Bityutskiy Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 13/14] writeback: remove unnecessary init_timer call Message-ID: <20100723162811.GC29633@infradead.org> References: <1279897554-1526-1-git-send-email-dedekind1@gmail.com> <1279897554-1526-14-git-send-email-dedekind1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1279897554-1526-14-git-send-email-dedekind1@gmail.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 17 On Fri, Jul 23, 2010 at 06:05:53PM +0300, Artem Bityutskiy wrote: > From: Artem Bityutskiy > > The 'setup_timer()' function also calls 'init_timer()', so the extra > 'init_timer()' call is not needed. Indeed, 'setup_timer()' is basically > 'init_timer()' plus callback function and data pointers initialization. Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/