Message-ID: <4C4A4681.4070901@codeaurora.org>
Date: Fri, 23 Jul 2010 18:48:49 -0700
From: Patrick Pannuto <ppannuto@codeaurora.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12pre) Gecko/20100715 Shredder/3.0.7pre
MIME-Version: 1.0
To: Greg KH <greg@kroah.com>
CC: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
        Emese Revfy <re.emese@gmail.com>,
        Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH 2/6] Driver core: Fix memory leak on bus_register error
 path
References: <1279836546-26913-1-git-send-email-ppannuto@codeaurora.org> <1279836546-26913-3-git-send-email-ppannuto@codeaurora.org> <20100722234107.GB674@kroah.com> <4C4A3F9B.6040600@codeaurora.org>
In-Reply-To: <4C4A3F9B.6040600@codeaurora.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1916
Lines: 58

>>>  
>>>  	retval = kset_register(&priv->subsys);
>>> -	if (retval)
>>> +	if (retval) {
>>> +		kfree(priv->subsys.kobj.name);
>>
>> I don't think we want to bury the logic of how kobject names are handled
>> up here in the bus code, right?  Shouldn't the subsys kobject name be
>> able to be cleaned up on its own somehow instead?
>>
> 
> So, my first instinct was to use kobject_cleanup, but a few lines above:
> 
> 	priv->subsys.kobj.ktype = &bus_ktype;
> 
> and bus_ktype's definition, with the notable absence of a release method:
> 
> static struct kobj_type bus_ktype = {
> 	.sysfs_ops	= &bus_sysfs_ops,
> };
> 
> which in kobject_cleanup would yield:
> 
> 	struct kobj_type *t = get_ktype(kobj);
> 
> 	if (t && !t->release)
> 		pr_debug("kobject: '%s' (%p): does not have a release() "
> 			 "function, it is broken and must be fixed.\n",
> 			 kobject_name(kobj), kobj);
> 
> (if I understand everything correctly)
> 

Thinking about this more, how does this ever work "correctly"? If we
chase the 'normal' path from bus_unregister...

given bus->p->subsys.kobj.ktype = &bus_ktype

bus_unregister(struct bus_type *bus) {
   kset_unregister(&bus->p->subsys) {
      kobject_put(&k->kobj) {
         kref_put(&kobj->kref, kobject_release) {
            (assuming last ref)
            kobject_cleanup(container_of(kref, struct kobject, kref)) {
               	struct kobj_type *t = get_ktype(kobj);

		if (t && !t->release)
			pr_debug("kobject: '%s' (%p): does not have a release() "
				 "function, it is broken and must be fixed.\n",
				 kobject_name(kobj), kobj);

Wouldn't this get hit every time a bus unregisters?  I feel like I'm
missing something here?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/