Subject: Re: [PATCHv5 12/15] writeback: optimize periodic bdi thread wakeups
From: Artem Bityutskiy <dedekind1@gmail.com>
Reply-To: dedekind1@gmail.com
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
In-Reply-To: <1280046581-23623-13-git-send-email-dedekind1@gmail.com>
References: <1280046581-23623-1-git-send-email-dedekind1@gmail.com>
	 <1280046581-23623-13-git-send-email-dedekind1@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Sun, 25 Jul 2010 13:41:09 +0300
Message-ID: <1280054469.9990.16.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 977
Lines: 31

On Sun, 2010-07-25 at 11:29 +0300, Artem Bityutskiy wrote:
> +static void wakeup_timer_fn(unsigned long data)
> +{
> +	struct backing_dev_info *bdi = (struct backing_dev_info *)data;
> +
> +	spin_lock(&bdi->wb_lock);
> +	if (bdi->wb.task) {
> +		wake_up_process(bdi->wb.task);
> +	} else {
> +		/*
> +		 * When bdi tasks are inactive for long time, they are killed.
> +		 * In this case we have to wake-up the forker thread which
> +		 * should create and run the bdi thread.
> +		 */
> +		wake_up_process(default_backing_dev_info.wb.task);
> +	}
> +	spin_unlock(&bdi->wb_lock);
> +}

OK, since now we use this lock in a timer, this should become a
spin_lock_bh().

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/