Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751694Ab0GYRDL (ORCPT ); Sun, 25 Jul 2010 13:03:11 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:36052 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919Ab0GYRDJ convert rfc822-to-8bit (ORCPT ); Sun, 25 Jul 2010 13:03:09 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=KllC+vYmvh6ZefZw48PptjdLr1O30HbrByKBfhIJN8unksoNtvy3it/sIj7IyuE6ty 49neyZggHz29a3ZBWhlvC0xcp2pFo/Y6QJJNcOw6cuzz/AyNhbKRvJatwWkV17sV9r0d 6yTg7sSglJ48yP4Cm5b3AEaKmMfXdDxHIqnXA= MIME-Version: 1.0 In-Reply-To: <1280066561-8543-1-git-send-email-minchan.kim@gmail.com> References: <1280066561-8543-1-git-send-email-minchan.kim@gmail.com> Date: Sun, 25 Jul 2010 22:33:08 +0530 X-Google-Sender-Auth: e6JpihvtdBHiG6FY2W_Mo7GkNvc Message-ID: Subject: Re: [PATCH] Tight check of pfn_valid on sparsemem - v3 From: Balbir Singh To: Minchan Kim Cc: Andrew Morton , linux-mm , linux-arm-kernel , LKML , Kukjin Kim , KAMEZAWA Hiroyuki , Mel Gorman , Johannes Weiner , Russell King Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 34 On Sun, Jul 25, 2010 at 7:32 PM, Minchan Kim wrote: > Changelog since v2 > ?o Change some function names > ?o Remove mark_memmap_hole in memmap bring up > ?o Change CONFIG_SPARSEMEM with CONFIG_ARCH_HAS_HOLES_MEMORYMODEL > > I have a plan following as after this patch is acked. > > TODO: > 1) expand pfn_valid to FALTMEM in ARM > I think we can enhance pfn_valid of FLATMEM in ARM. > Now it is doing binary search and it's expesive. > First of all, After we merge this patch, I expand it to FALTMEM of ARM. > > 2) remove memmap_valid_within > We can remove memmap_valid_within by strict pfn_valid's tight check. > > 3) Optimize hole check in sparsemem > In case of spasemem, we can optimize pfn_valid through defining new flag > like SECTION_HAS_HOLE of hole mem_section. > Is there an assumption somewhere that assumes that page->private will always have MEMMAP_HOLE set when the pfn is invalid, independent of the context in which it is invoked? BTW, I'd also recommend moving over to using set_page_private() and page_private() wrappers (makes the code easier to search) Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/