Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S316408AbSFZFzw>; Wed, 26 Jun 2002 01:55:52 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S316416AbSFZFzv>; Wed, 26 Jun 2002 01:55:51 -0400
Received: from astound-64-85-224-253.ca.astound.net ([64.85.224.253]:8465 "EHLO
	master.linux-ide.org") by vger.kernel.org with ESMTP
	id <S316408AbSFZFzu>; Wed, 26 Jun 2002 01:55:50 -0400
Date: Tue, 25 Jun 2002 22:50:42 -0700 (PDT)
From: Andre Hedrick <andre@linux-ide.org>
To: "Shen, JT" <JT.Shen@hp.com>
cc: linux-kernel@vger.kernel.org
Subject: Re: ide driver bug fix for the error message "hda: bad special flag
 0x03"
In-Reply-To: <5A96E87E2BA0714ABBEA2C8F3F3F667C0AA680@cceexc19.americas.cpqcorp.net>
Message-ID: <Pine.LNX.4.10.10206252250280.28989-100000@master.linux-ide.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1512
Lines: 52


Cool!

Thanks!

On Tue, 25 Jun 2002, Shen, JT wrote:

> diff -Naur linux-2.4.19-10/drivers/ide/ide-probe.c linux-2.4.19-11/drivers/ide/ide-probe.c
> --- linux-2.4.19-10/drivers/ide/ide-probe.c	Fri Jun 21 15:14:46 2002
> +++ linux-2.4.19-11/drivers/ide/ide-probe.c	Mon Jun 24 15:19:15 2002
> @@ -131,6 +131,7 @@
>  				type = ide_cdrom;	/* Early cdrom models used zero */
>  			case ide_cdrom:
>  				drive->removable = 1;
> +				drive->special.all = 0;
>  #ifdef CONFIG_PPC
>  				/* kludge for Apple PowerBook internal zip */
>  				if (!strstr(id->model, "CD-ROM") && strstr(id->model, "ZIP")) {
> 
> 
> 
> 
> 
> 
> 
> 
> Andre,
> 
> Above is the patch that will fix the bug that when a user issue the command:
> 
>    cat /proc/ide/hda/identify
> 
> the message "hda: bad special flag 0x03" gets written to the system log.  This will happen because the .config file that RedHat uses to create the kernel image has the flag CONFIG_BLK_DEV_IDECD=m.  Thus in ide.c code, it won't call ide_cdrom_reinit(). So for CDROM the special flag is left as 0x03.
> 
> 
> The solution is to set the special flags to 0 when it is discovered as cdrom in ide-probe.c.
> 
> Let me know if you have any question.
> 
> Thanks,
> 
> JT  
> 

Andre Hedrick
LAD Storage Consulting Group

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/