Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753870Ab0GZJI4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 26 Jul 2010 05:08:56 -0400
Received: from mail-ww0-f44.google.com ([74.125.82.44]:42194 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751488Ab0GZJIz convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 26 Jul 2010 05:08:55 -0400
MIME-Version: 1.0
In-Reply-To: <20100722183614.GA5443@suse.de>
References: <20100722182638.GA12712@kroah.com>
	<AANLkTinRGBksuWAZhdmvr39FNACU18+kc5ut49VUf=mp@mail.gmail.com>
	<20100722183614.GA5443@suse.de>
Date: Mon, 26 Jul 2010 11:08:53 +0200
Message-ID: <AANLkTinsd2gWOHb3w9gzvKO5vdwLBT7DZOY+2xCUz_5_@mail.gmail.com>
Subject: Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on
From: Dhaval Giani <dhaval.lists@thegianis.in>
To: Greg KH <gregkh@suse.de>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
        Lennart Poettering <lennart@poettering.net>,
        Kay Sievers <kay.sievers@vrfy.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        Ben Blum <bblum@andrew.cmu.edu>, containers@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1359
Lines: 30

On Thu, Jul 22, 2010 at 8:36 PM, Greg KH <gregkh@suse.de> wrote:
> On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote:
>> On Thu, Jul 22, 2010 at 11:26 AM, Greg KH <gregkh@suse.de> wrote:
>> > We really shouldn't be asking userspace to create new root filesystems.
>> > So follow along with all of the other in-kernel filesystems, and provide
>> > a mount point in sysfs.
>> >
>> > For cgroupfs, this should be in /sys/fs/cgroup/ ?This change provides
>> > that mount point when the cgroup filesystem is registered in the kernel.
>>
>> But cgroups will typically have multiple mounts, with different
>> resource controllers/options on each mount. That doesn't really fit in
>> with this scheme.
>
> Really? ?I see systems mounting it at /cgroups/ in the filesystem today.
> Where are you expecting it to be mounted at?
>

Not really. It is getting mounted at /cgroups/<name of resource
controller>/ at a number of places. Keeping it in sysfs loses us a lot
of this flexibility. Unless you are ready to keep adding a new
mountpoint for each subsystem, it will not really work out in the long
term.

Dhaval
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/