Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753892Ab0GZNLp (ORCPT ); Mon, 26 Jul 2010 09:11:45 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:60327 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815Ab0GZNLn (ORCPT ); Mon, 26 Jul 2010 09:11:43 -0400 Date: Mon, 26 Jul 2010 14:11:22 +0100 From: Russell King - ARM Linux To: Michal Marek Cc: Mikael Pettersson , Robert Nelson , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm: Build with -fno-dwarf2-cfi-asm Message-ID: <20100726131122.GD23399@n2100.arm.linux.org.uk> References: <1278710019-3667-1-git-send-email-mmarek@suse.cz> <19512.28505.216012.603468@pilspetsen.it.uu.se> <4C4D87D2.3090805@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C4D87D2.3090805@suse.cz> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2168 Lines: 52 On Mon, Jul 26, 2010 at 03:04:18PM +0200, Michal Marek wrote: > On 10.7.2010 15:02, Mikael Pettersson wrote: > > Michal Marek writes: > > > Commit d0679c7 restricted this workaround to powerpc only, but it turns > > > out that ARM needs it as well. Fixes > > > https://bugzilla.kernel.org/show_bug.cgi?id=16310 . > > > > > > Reported-and-Tested-by: Robert Nelson > > > Signed-off-by: Michal Marek > > > --- > > > arch/arm/Makefile | 5 +++++ > > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > > > index 64ba313..862d4ba 100644 > > > --- a/arch/arm/Makefile > > > +++ b/arch/arm/Makefile > > > @@ -21,6 +21,11 @@ GZFLAGS :=-9 > > > # Explicitly specifiy 32-bit ARM ISA since toolchain default can be -mthumb: > > > KBUILD_CFLAGS +=$(call cc-option,-marm,) > > > > > > +# FIXME: the module load should be taught about the additional relocs > > > +# generated by this. > > > +# revert to pre-gcc-4.4 behaviour of .eh_frame > > > +KBUILD_CFLAGS += $(call cc-option,-fno-dwarf2-cfi-asm) > > > > Appears related to gcc PR40521, which should be fixed in gcc-4.4.3, > > though it may have been re-broken in gcc-4.5.0 for in a corner case > > that may or > > may not apply to the kernel. There's also a related binutils issue. > > > > The above fix seems appropriate, but the FIXME comment seems wrong: > > this is about getting the right kind of exception unwind tables in > > the entire kernel, not just relocs in modules. > > > > The comment should just say: > > # Never generate .eh_frame: > > > > So for the fix without the comment part: > > > > Acked-by: Mikael Pettersson > > Hi Russell, > > should I resend the patch with the comment by Mikael? Yes please - and please put it in the patch system. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/