Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754257Ab0GZOEp (ORCPT ); Mon, 26 Jul 2010 10:04:45 -0400 Received: from h5.dl5rb.org.uk ([81.2.74.5]:53326 "EHLO h5.dl5rb.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247Ab0GZOEn (ORCPT ); Mon, 26 Jul 2010 10:04:43 -0400 Date: Mon, 26 Jul 2010 15:04:17 +0100 From: Ralf Baechle To: Kulikov Vasiliy Cc: kernel-janitors@vger.kernel.org, Chris Dearman , "Robert P. J. Day" , Rusty Russell , =?iso-8859-1?Q?Andr=E9?= Goddard Rosa , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk() Message-ID: <20100726140417.GA12084@linux-mips.org> References: <1279130502-10777-1-git-send-email-segooon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1279130502-10777-1-git-send-email-segooon@gmail.com> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 545 Lines: 16 On Wed, Jul 14, 2010 at 10:01:42PM +0400, Kulikov Vasiliy wrote: > Use %p instead of %08x in printk(). Queued for 2.6.36, thanks! Yes, %p is prefered here. But your log message doesn't mention that your patch also does a functional change, it drops the 0x prefix of the printed value ... Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/