Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754021Ab0GZPEp (ORCPT ); Mon, 26 Jul 2010 11:04:45 -0400 Received: from cantor.suse.de ([195.135.220.2]:43778 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144Ab0GZPEo convert rfc822-to-8bit (ORCPT ); Mon, 26 Jul 2010 11:04:44 -0400 Date: Mon, 26 Jul 2010 17:04:43 +0200 Message-ID: From: Takashi Iwai To: Jiri Slaby Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , fengguang.wu@intel.com, LKML Subject: Re: hda_intel: too quiet sound (regression) In-Reply-To: <4C4D9EDA.3060505@gmail.com> References: <4C4D9EDA.3060505@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 59 At Mon, 26 Jul 2010 16:42:34 +0200, Jiri Slaby wrote: > > Hi, > > after I upgraded from 2.6.34-rc5-mm1 to 2.6.35-rc5-mm1 (there were other > issues in between them), the sound from my soundcard is very very quiet. > > alsa-info: > http://www.alsa-project.org/db/?f=dcadb29a2d5d047ecf5545792ac3239dc0c8c7f0 > > Any ideas? Looks like a regression by the amp max value check. The following patch should fix the problem. thanks, Takashi --- >From 7ccc3eface57b6e1773fce009dac8a3da081b8b1 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Mon, 26 Jul 2010 17:00:15 +0200 Subject: [PATCH] ALSA: hda - Fix max amp cap calculation for IDT/STAC codecs The commit afbd9b8448f4b7d15673c6858012f384f18d28b8 ALSA: hda - Limit the amp value to write introduced a regression for codec setups with amp offsets like IDT/STAC codecs. The limit value should be a raw value without offset calculation. Signed-off-by: Takashi Iwai --- sound/pci/hda/hda_codec.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 501cbc4..e5c3484 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -1629,7 +1629,8 @@ update_amp_value(struct hda_codec *codec, hda_nid_t nid, if (val > 0) val += ofs; - maxval = get_amp_max_value(codec, nid, dir, ofs); + /* ofs = 0: raw max value */ + maxval = get_amp_max_value(codec, nid, dir, 0); if (val > maxval) val = maxval; return snd_hda_codec_amp_update(codec, nid, ch, dir, idx, -- 1.7.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/