Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040Ab0G0CSR (ORCPT ); Mon, 26 Jul 2010 22:18:17 -0400 Received: from mga09.intel.com ([134.134.136.24]:6987 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496Ab0G0CSP (ORCPT ); Mon, 26 Jul 2010 22:18:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.55,264,1278313200"; d="scan'208";a="641890499" Subject: Re: [RFC][PATCH v1 02/15] perf: export generic hardware events via sysfs From: Lin Ming To: Robert Richter Cc: Ingo Molnar , Corey Ashford , Johannes Berg , Peter Zijlstra , Greg KH , Frederic Weisbecker , Paul Mundt , "eranian@gmail.com" , "Gary.Mohr@Bull.com" , "arjan@linux.intel.com" , "Zhang, Yanmin" , Paul Mackerras , "David S. Miller" , Russell King , Arnaldo Carvalho de Melo , Will Deacon , Maynard Johnson , Carl Love , Kay Sievers , lkml , Thomas Gleixner , Steven Rostedt In-Reply-To: <20100723104412.GA26154@erda.amd.com> References: <1279797142.20942.83.camel@minggr.sh.intel.com> <20100723104412.GA26154@erda.amd.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 27 Jul 2010 10:18:23 +0800 Message-ID: <1280197103.24607.61.camel@minggr.sh.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3419 Lines: 97 On Fri, 2010-07-23 at 18:44 +0800, Robert Richter wrote: > On 22.07.10 07:12:22, Lin Ming wrote: > > Generic hardware events are exported under > > /sys/devices/system/cpu/cpu0...N/events, for example > > > > /sys/devices/system/cpu/cpu0/events > > |-- L1-dcache-load-misses > > | |-- config > > | `-- type > > The sysfs approach came up as a solution to connect to dynamically > added pmus of various kind of hardware. The current mechanism using > config/type style did not fit anymore because we would have to > continuously extend the syscall i/f by new flags and attributes for > every new event. So, the problem is not which config and type > parameters to use for creating an event, we need a _different_ way for > this. > > The config and type value you expose to sysfs are only used for > setting up the syscall. So, I want to bring up my idea again here that > I posted some days ago to lkml, using a unique sysfs id to specify > event classes. > > Simply export an id (an u64), like: > > |-- L1-dcache-load-misses ===> event name > | `-- id ===> event id > > ... and then extend the syscall to enable an event by its sysfs id: > > memset(&attr, 0, sizeof(attr)); > attr.type = PERF_TYPE_SYSFS; > attr.sysfs_id = sysfs_id; > attr.sample_type = PERF_SAMPLE_CPU | PERF_SAMPLE_RAW; > attr.config = config; > ... > > The config value can then be (re-)used to setup this _specific_ event > individually. > > The kernel knows the id and is able to route the event request > directly to that particular pmu, something like: > > struct event_kobject { > struct kobject *kobj; > u64 id; > struct pmu *pmu; > struct event_kobject *next; > }; > > struct event_kobject *eclass; > > eclass = find_event_kobject(id); > eclass->pmu->event_init(event); > ... > > This is very simple and flexible and solves the original problem too. Yeah, this is flexible. I'll think about this closely. Thanks, Lin Ming > > (reposting my previous mail:) > > You still need knowledge of what the event is measuring and how it is > set up or configured. Maybe the configuration may left blank if the > event can be setup without it. But with this approach you can get file > descriptors for every event a user may be interested in simply by > looking into sysfs. > > For example, I was thinking of perfctr events vs. ibs events. The cpu > could setup something like: > > /sys/devices/system/cpu/cpu0...cpuN/events/perfctr/id > /sys/devices/system/cpu/cpu0...cpuN/events/ibs_op/id > > Both events are setup with one 64 bit config value that is basically > the event's configuration msr (x86 perfctr or AMD IBS). These are > definded in the hardware specifications. Its formats differ. You could > then open the event file descriptor using the sysfs id and use the > config value to customize the event. You don't have a complicated > setup or implementation to detect which kind of event you want to use > as the id indicates the type of event. > > Actually, we could setup e.g. also trace events with this mechanism. > > -Robert > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/