Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754541Ab0G0N33 (ORCPT ); Tue, 27 Jul 2010 09:29:29 -0400 Received: from mail1-out1.atlantis.sk ([80.94.52.55]:56488 "EHLO mail.atlantis.sk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753108Ab0G0N31 (ORCPT ); Tue, 27 Jul 2010 09:29:27 -0400 To: Russell King Subject: [PATCH] [resend] cyber2000fb: fix machine hang on module load Cc: linux-fbdev@vger.kernel.org, Kernel development list Content-Disposition: inline From: Ondrej Zary Date: Tue, 27 Jul 2010 15:29:20 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201007271529.22520.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 29 Hello, I was testing two CyberPro 2000 based PCI cards on x86 and the machine always hanged completely when the cyber2000fb module was loaded. It seems that the card hangs when some registers are accessed too quickly after writing RAMDAC control register. With this patch, both card work. Add delay after RAMDAC control register write to prevent hangs on module load. Signed-off-by: Ondrej Zary --- linux-2.6.35-rc2/drivers/video/cyber2000fb.c 2010-06-06 05:43:24.000000000 +0200 +++ linux-2.6.35-rc3/drivers/video/cyber2000fb.c 2010-07-25 18:20:47.000000000 +0200 @@ -436,6 +436,7 @@ static void cyber2000fb_write_ramdac_ctr cyber2000fb_writeb(i | 4, 0x3cf, cfb); cyber2000fb_writeb(val, 0x3c6, cfb); cyber2000fb_writeb(i, 0x3cf, cfb); + udelay(1); } static void cyber2000fb_set_timing(struct cfb_info *cfb, struct par_info *hw) -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/