Date: Tue, 27 Jul 2010 19:33:22 +0530
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@elte.hu>,
        Steven Rostedt <rostedt@goodmis.org>,
        Randy Dunlap <rdunlap@xenotime.net>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Christoph Hellwig <hch@infradead.org>, Oleg Nesterov <oleg@redhat.com>,
        Mark Wielaard <mjw@redhat.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Naren A Devaiah <naren.devaiah@in.ibm.com>,
        Jim Keniston <jkenisto@linux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        "Frank Ch. Eigler" <fche@redhat.com>,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        2nddept-manager@sdl.hitachi.co.jp
Subject: Re: [PATCHv10 2.6.35-rc6-tip 8/14]  trace: Extract out common code
 for kprobes/uprobes traceevents.
Message-ID: <20100727140322.GB21723@linux.vnet.ibm.com>
Reply-To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
References: <20100727110855.24690.26901.sendpatchset@localhost6.localdomain6>
 <20100727111035.24690.27211.sendpatchset@localhost6.localdomain6>
 <4C4EDDAD.4010805@hitachi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <4C4EDDAD.4010805@hitachi.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1629
Lines: 43

> 
> > ---
> [...]
> > +/* Recursive argument parser */
> > +static int parse_probe_arg(char *arg, const struct fetch_type *t,
> > +		     struct fetch_param *f, int is_return, bool is_kprobe)
> 
> If you use "bool" for "is_kprobe", change "is_return" type too.

Okay. 


> 
> And, maybe you missed that the fetch function supports "string" type now,
> which needs a bit different manner for storing fetched value. You can find
> store_trace_args() function in trace_kprobe.c.

Yes, I have seen your changes for supporting string type.  Though all
the fetch functions are in common code, uprobe based probes for now
supports register fetching only. We have to add support for other
types gradually. Please let me know if you see a reason to change the
way we fetch even when we only support register type access.

> 
> BTW, current fetch functions doesn't support fetching "paged-out" user-variables
> because kprobe can't sleep inside its handler.
> However, user-space memory can be paged out, and I assume that uprobes allows
> its handler to I/O (and yield). If so, it can wait for accessing paged-out
> variable, can't it?

Yes, the uprobes handler might sleep and hence we would have to
handle accessing the paged-out user variables. When perf-uprobes
starts supporting dwarf based probing, we should look into these
issues.  Currently its a todo.

--
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/