Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756023Ab0G0Pc4 (ORCPT ); Tue, 27 Jul 2010 11:32:56 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:34594 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753580Ab0G0Pcz (ORCPT ); Tue, 27 Jul 2010 11:32:55 -0400 Date: Tue, 27 Jul 2010 17:32:31 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Andrew Morton Cc: Gregory Bean , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jani Nikula , David Brownell , Greg Kroah-Hartman , Jon Povey Subject: Re: [PATCH] gpio: remove spurious gpio_unexport debug error. Message-ID: <20100727153231.GA7072@pengutronix.de> References: <1279832758-25442-1-git-send-email-gbean@codeaurora.org> <20100723045807.GA14875@pengutronix.de> <20100726153236.ead96c88.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100726153236.ead96c88.akpm@linux-foundation.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 40 Hello Andrew, On Mon, Jul 26, 2010 at 03:32:36PM -0700, Andrew Morton wrote: > On Fri, 23 Jul 2010 06:58:07 +0200 > Uwe Kleine-K__nig wrote: > > > Hello, > > > > On Thu, Jul 22, 2010 at 02:05:58PM -0700, Gregory Bean wrote: > > > Make gpio_unexport generate success instead of an -EINVAL > > > if asked to unexport a line which is not exported, because > > > the only result of that condition is a pr_debug > > > which complains of what is really a harmless no-op: > > > when an unexported gpio is unexported again, nothing happens. > > > That's not a failure, just a trivial border case. > > > Since gpio_free calls gpio_unexport unconditionally > > > and exported gpio lines are uncommon, most calls to > > > gpio_free with debug flags enabled generate -EINVAL > > > warnings in the log, causing unnecessary stress. > > I noticed that a few days ago, too. Just didn't come around to fix it > > myself. > > > > > Signed-off-by: Gregory Bean > > Acked-by: Uwe Kleine-K__nig > > > > Jon got there first ;) OK, then he can get my ack, too. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/