Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751358Ab0G0QZW (ORCPT ); Tue, 27 Jul 2010 12:25:22 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:53660 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750889Ab0G0QZV (ORCPT ); Tue, 27 Jul 2010 12:25:21 -0400 Date: Tue, 27 Jul 2010 17:25:11 +0100 From: Russell King - ARM Linux To: Ondrej Zary Cc: linux-fbdev@vger.kernel.org, Kernel development list Subject: Re: [PATCH] [resend] cyber2000fb: fix machine hang on module load Message-ID: <20100727162510.GB17099@n2100.arm.linux.org.uk> References: <201007271529.22520.linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201007271529.22520.linux@rainbow-software.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 931 Lines: 19 On Tue, Jul 27, 2010 at 03:29:20PM +0200, Ondrej Zary wrote: > Hello, > I was testing two CyberPro 2000 based PCI cards on x86 and the machine always > hanged completely when the cyber2000fb module was loaded. It seems that the > card hangs when some registers are accessed too quickly after writing RAMDAC > control register. With this patch, both card work. > > Add delay after RAMDAC control register write to prevent hangs on module load. This one on the other hand I think is rather too heavy. What might be better is to re-code the last register write to use the x86 outb_p() stuff to slow it down, rather than using udelay(). Could you try something along those lines please? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/