Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752805Ab0G0RkM (ORCPT ); Tue, 27 Jul 2010 13:40:12 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59389 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228Ab0G0RkK (ORCPT ); Tue, 27 Jul 2010 13:40:10 -0400 Subject: Re: [PATCH] aic7xxx: Remove OS utility wrappers From: James Bottomley To: Hannes Reinecke Cc: Pekka Enberg , linux-kernel@vger.kernel.org, Jiri Kosina , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , =?ISO-8859-1?Q?Andr=E9?= Goddard Rosa , linux-scsi@vger.kernel.org In-Reply-To: <4C43F3DE.8000405@suse.de> References: <1279102377-958-1-git-send-email-penberg@cs.helsinki.fi> <4C43F3DE.8000405@suse.de> Content-Type: text/plain; charset="UTF-8" Date: Tue, 27 Jul 2010 12:40:04 -0500 Message-ID: <1280252404.2833.168.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1664 Lines: 38 On Mon, 2010-07-19 at 08:42 +0200, Hannes Reinecke wrote: > Pekka Enberg wrote: > > This patch removes malloc(), free(), and printf() wrappers from the aic7xxx > > SCSI driver. I didn't use pr_debug for printf because of some 'clever' uses of > > printf don't compile with the pr_debug. I didn't fix the overeager uses of > > GFP_ATOMIC either because I wanted to keep this patch as simple as possible. > > > > Cc: Hannes Reinecke > > Cc: "James E.J. Bottomley" > > Cc: Jiri Kosina > > Cc: "Uwe Kleine-König" > > Cc: "André Goddard Rosa" > > Cc: > > Signed-off-by: Pekka Enberg > > Thanks for the work. Long overdue. > > Acked-by: Hannes Reinecke A good rule of thumb is compile before acking: drivers/scsi/aic7xxx/aic7770.c: In function 'aic7770_config': drivers/scsi/aic7xxx/aic7770.c:224: error: implicit declaration of function 'free' drivers/scsi/aic7xxx/aic7770.c:224: error: 'M_DEVBUF' undeclared (first use in this function) drivers/scsi/aic7xxx/aic7770.c:224: error: (Each undeclared identifier is reported only once drivers/scsi/aic7xxx/aic7770.c:224: error: for each function it appears in.) make[3]: *** [drivers/scsi/aic7xxx/aic7770.o] Error 1 It looks like a lone missed conversion, so I fixed it up. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/