Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752253Ab0G0TFE (ORCPT ); Tue, 27 Jul 2010 15:05:04 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43956 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750964Ab0G0TFD (ORCPT ); Tue, 27 Jul 2010 15:05:03 -0400 Message-ID: <4C4F2D9C.4020303@zytor.com> Date: Tue, 27 Jul 2010 12:03:56 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jeremy Fitzhardinge , alex.williamson@redhat.com, FUJITA Tomonori , Albert Herranz , Ian Campbell , Thomas Gleixner , x86@kernel.org, Jesse Barnes Subject: Re: [PATCH 9/9] x86: Detect whether we should use Xen SWIOTLB. References: <1280250002-20279-1-git-send-email-konrad.wilk@oracle.com> <1280250002-20279-10-git-send-email-konrad.wilk@oracle.com> In-Reply-To: <1280250002-20279-10-git-send-email-konrad.wilk@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 34 On 07/27/2010 10:00 AM, Konrad Rzeszutek Wilk wrote: > It is paramount that we call pci_xen_swiotlb_detect before > pci_swiotlb_detect as both implementations use the 'swiotlb' > and 'swiotlb_force' flags. The pci-xen_swiotlb_detect inhibits > the swiotlb_force and swiotlb flag so that the native SWIOTLB > implementation is not enabled when running under Xen. > > Signed-off-by: Konrad Rzeszutek Wilk > Acked-by: Jeremy Fitzhardinge > Cc: FUJITA Tomonori > Cc: Albert Herranz > Cc: Ian Campbell > Cc: Thomas Gleixner > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Jesse Barnes > --- > arch/x86/kernel/pci-dma.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > Is there any way we can abstract this out a bit more instead of crapping on generic code? -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/