Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811Ab0G0TRH (ORCPT ); Tue, 27 Jul 2010 15:17:07 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51028 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702Ab0G0TRF (ORCPT ); Tue, 27 Jul 2010 15:17:05 -0400 Date: Tue, 27 Jul 2010 12:16:10 -0700 From: Andrew Morton To: Patrick Pannuto Cc: Jonathan Corbet , Israel Schlesinger , linux-kernel@vger.kernel.org, apw@canonical.com, joe@perches.com, Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH] checkpatch: Add warnings for use of mdelay() Message-Id: <20100727121610.64b38cfa.akpm@linux-foundation.org> In-Reply-To: <4C4F1846.3090103@codeaurora.org> References: <4C4F132F.6020401@codeaurora.org> <20100727113133.1605c9fe@bike.lwn.net> <4C4F1846.3090103@codeaurora.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4052 Lines: 110 On Tue, 27 Jul 2010 10:32:54 -0700 Patrick Pannuto wrote: > On 07/27/2010 10:31 AM, Jonathan Corbet wrote: > > On Tue, 27 Jul 2010 10:11:11 -0700 > > Israel Schlesinger wrote: > > > >> mdelay is a busy-wait loop which is wasteful. If at all possible, > >> callers should use msleep instead of mdelay. > >> > >> The only time mdelay is really appropriate is in atomic context, > >> however, delays of 1ms+ in atomic context are rather expensive, so > >> a warning for this case is probably appropriate as well to encourage > >> people to move such expensive delays outside of atomic context > > > > Once upon a time, msleep(1) would sleep for 20ms, while mdelay(1) gave > > a 1ms delay. My patch to fix msleep() at that time didn't get in due > > to concerns about the cost of using hrtimers. Perhaps msleep() has > > gotten better, but, if not, actually getting a 1ms delay remains a > > valid reason for using mdelay() instead IMO. It made a difference of a > > few seconds at open time for a driver I was doing at the time. > > > > jon > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > Check out the recently added usleep in -tip, and the checkpatch patch > pending in my queue that fixes that case (I'll send in a few hours ;) ) > The message should point people at usleep_range(), I'd suggest. It's a more power-friendly way of sleeping. That assumes that the below patch gets merged - the people who handle timer-related things are presently, err, asleep. From: Patrick Pannuto usleep[_range] are finer precision implementations of msleep and are designed to be drop-in replacements for udelay where a precise sleep / busy-wait is unnecessary. They also allow an easy interface to specify slack when a precise (ish) wakeup is unnecessary to help minimize wakeups Signed-off-by: Patrick Pannuto Acked-by: Arjan van de Ven Cc: Ingo Molnar Cc: Thomas Gleixner Signed-off-by: Andrew Morton --- include/linux/delay.h | 6 ++++++ kernel/timer.c | 22 ++++++++++++++++++++++ 2 files changed, 28 insertions(+) diff -puN include/linux/delay.h~timers-add-usleep-timer include/linux/delay.h --- a/include/linux/delay.h~timers-add-usleep-timer +++ a/include/linux/delay.h @@ -45,6 +45,12 @@ extern unsigned long lpj_fine; void calibrate_delay(void); void msleep(unsigned int msecs); unsigned long msleep_interruptible(unsigned int msecs); +void usleep_range(unsigned long min, unsigned long max); + +static inline void usleep(unsigned long usecs) +{ + usleep_range(usecs, usecs); +} static inline void ssleep(unsigned int seconds) { diff -puN kernel/timer.c~timers-add-usleep-timer kernel/timer.c --- a/kernel/timer.c~timers-add-usleep-timer +++ a/kernel/timer.c @@ -1763,3 +1763,25 @@ unsigned long msleep_interruptible(unsig } EXPORT_SYMBOL(msleep_interruptible); + +static int __sched do_usleep_range(unsigned long min, unsigned long max) +{ + ktime_t kmin; + unsigned long delta; + + kmin = ktime_set(0, min * NSEC_PER_USEC); + delta = max - min; + return schedule_hrtimeout_range(&kmin, delta, HRTIMER_MODE_REL); +} + +/** + * usleep_range - Drop in replacement for udelay where wakeup is flexible + * @min: Minimum time in usecs to sleep + * @max: Maximum time in usecs to sleep + */ +void usleep_range(unsigned long min, unsigned long max) +{ + __set_current_state(TASK_UNINTERRUPTIBLE); + do_usleep_range(min, max); +} +EXPORT_SYMBOL(usleep_range); _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/