Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527Ab0G1Ern (ORCPT ); Wed, 28 Jul 2010 00:47:43 -0400 Received: from ozlabs.org ([203.10.76.45]:40942 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751235Ab0G1Erl (ORCPT ); Wed, 28 Jul 2010 00:47:41 -0400 Date: Wed, 28 Jul 2010 14:47:31 +1000 From: Paul Mackerras To: Scott Wood Cc: Peter Zijlstra , Kumar Gala , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Ingo Molnar , Benjamin Herrenschmidt Subject: Re: Please pull my perf.git urgent branch Message-ID: <20100728044731.GA2408@brick.ozlabs.ibm.com> References: <20100727124019.GB14947@brick.ozlabs.ibm.com> <20100727112854.7bf97d48@schlenkerla.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100727112854.7bf97d48@schlenkerla.am.freescale.net> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1211 Lines: 32 On Tue, Jul 27, 2010 at 11:28:54AM -0500, Scott Wood wrote: > Doesn't the setting of .period need to be maintained (it is in the other > powerpc perf_event implementation that this is derived from)? Gah, yes it does. > I don't see how this is a security fix -- the existing initializer above > should zero-fill the fields that are not explicitly initialized. In fact, > it's taking other fields that were previously initialized to zero and is > making them uninitialized, since perf_sample_data_init only sets addr and > raw. So I misunderstood how an initializer for an automatic struct works. Brown paper bag time for me... :( Regarding the other fields, I assume Peter et al. have checked that they don't need to be cleared, so it's a microoptimization to not clear them. > CCing linuxppc-dev on the original patch would have been nice... True, but at least I can blame Peter Z. for that. :) Kumar and Ben, how do you want to proceed on this one? Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/