Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754531Ab0G1N74 (ORCPT ); Wed, 28 Jul 2010 09:59:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38107 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753926Ab0G1N7w (ORCPT ); Wed, 28 Jul 2010 09:59:52 -0400 Date: Wed, 28 Jul 2010 15:59:50 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Markus Grabner , gregkh@suse.de, devel@driverdev.osuosl.org Subject: Re: [PATCH -next] staging/line6: needs to select SND_PCM In-Reply-To: <4C4F31AF.2090701@oracle.com> References: <20100727160708.722c39c1.sfr@canb.auug.org.au> <4C4F31AF.2090701@oracle.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2168 Lines: 54 At Tue, 27 Jul 2010 12:21:19 -0700, Randy Dunlap wrote: > > From: Randy Dunlap > > line6 uses snd_pcm*() functions, so it should select SND_PCM. > > ERROR: "snd_pcm_period_elapsed" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_set_ops" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_lib_free_pages" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_lib_ioctl" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_lib_malloc_pages" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_hw_constraint_ratdens" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_format_physical_width" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_lib_preallocate_pages_for_all" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_new" [drivers/staging/line6/line6usb.ko] undefined! > > Signed-off-by: Randy Dunlap > Cc: Markus Grabner > --- > drivers/staging/line6/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Third patch to staging/line6/Kconfig. :( > Developers should know what kernel services their code needs > and how to configure for those needs. I think this should be applied rather to 2.6.35 tree. thanks, Takashi > --- linux-next-20100727.orig/drivers/staging/line6/Kconfig > +++ linux-next-20100727/drivers/staging/line6/Kconfig > @@ -2,6 +2,7 @@ config LINE6_USB > tristate "Line6 USB support" > depends on USB && SND > select SND_RAWMIDI > + select SND_PCM > help > This is a driver for the guitar amp, cab, and effects modeller > PODxt Pro by Line6 (and similar devices), supporting the > -- > To unsubscribe from this list: send the line "unsubscribe linux-next" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/