Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755515Ab0G1QDb (ORCPT ); Wed, 28 Jul 2010 12:03:31 -0400 Received: from cantor.suse.de ([195.135.220.2]:59884 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136Ab0G1QDa (ORCPT ); Wed, 28 Jul 2010 12:03:30 -0400 Date: Wed, 28 Jul 2010 18:03:29 +0200 Message-ID: From: Takashi Iwai To: "Mario 'BitKoenig' Holbe" Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [alsa-devel] Regression 2.6.35-rc6: ALSA Intel HDA/Realtek: missing Beep In-Reply-To: References: <20100728144903.GA18170@darkside.kls.lan> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2499 Lines: 72 At Wed, 28 Jul 2010 17:35:10 +0200, I wrote: > > At Wed, 28 Jul 2010 16:49:03 +0200, > Mario 'BitKoenig' Holbe wrote: > > > > Hello, > > > > My PC-Speaker Beep control worked in 2.6.34, but is gone in 2.6.35-rc6. > > The sound device is an Asus P5E-V HDMI (Intel G35) onboard Intel HDA w/ > > Realtek ALC883 codec. > > > > The driver does still register a PCBeep input, but the Controls as well > > as the sound (:)) are gone. > > > > HDA Intel 0000:00:1b.0: PCI INT A -> GSI 22 (level, low) -> IRQ 22 > > HDA Intel 0000:00:1b.0: irq 47 for MSI/MSI-X > > HDA Intel 0000:00:1b.0: setting latency timer to 64 > > input: HDA Digital PCBeep as /devices/pci0000:00/0000:00:1b.0/input/input5 > > > > $ diff card0-codec#0-2.6.34 card0-codec#0-2.6.35-rc6 > > 111,114d110 > > < Control: name="Beep Playback Volume", index=0, device=0 > > < ControlAmp: chs=3, dir=In, idx=5, ofs=0 > > < Control: name="Beep Playback Switch", index=0, device=0 > > < ControlAmp: chs=3, dir=In, idx=5, ofs=0 > > > > Attached /proc/asound/card0/codec#0 from 2.6.35-rc6. > > It's because now the driver checks the SSID your board sets up. > Realtek codecs suppose SSID containing some useful bits to inform > the h/w setups. The presence of PC beep is one of it. > So, it's actually BIOS that clears it. > > In the earlier version, the driver didn't check this. > > Actually, the real bug is that it still creates a beep device without > mixers. This should be avoided... Or, does the following patch fix? It's already in sound git tree, Takashi --- diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d7fd846..9295527 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -1267,11 +1267,11 @@ static int alc_auto_parse_customize_define(struct hda_codec *codec) unsigned nid = 0; struct alc_spec *spec = codec->spec; + spec->cdefine.enable_pcbeep = 1; /* assume always enabled */ + ass = codec->subsystem_id & 0xffff; - if (ass != codec->bus->pci->subsystem_device && (ass & 1)) { - spec->cdefine.enable_pcbeep = 1; /* assume always enabled */ + if (ass != codec->bus->pci->subsystem_device && (ass & 1)) goto do_sku; - } nid = 0x1d; if (codec->vendor_id == 0x10ec0260) -- 1.7.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/