Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755977Ab0G1Tdd (ORCPT ); Wed, 28 Jul 2010 15:33:33 -0400 Received: from imr1.ericy.com ([198.24.6.9]:43712 "EHLO imr1.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755557Ab0G1Td1 (ORCPT ); Wed, 28 Jul 2010 15:33:27 -0400 Subject: Re: [PATH V2 2/5] Package Level Thermal Control and Power Limit Notification: pkgtemp hwmon driver From: Guenter Roeck Reply-To: guenter.roeck@ericsson.com To: Fenghua Yu CC: Ingo Molnar , Thomas Gleixner , H Peter Anvin , Len Brown , Chen Gong , Jean Delvare , Huaxu Wan , linux-kernel , lm-sensors In-Reply-To: <1280343653-26380-3-git-send-email-fenghua.yu@intel.com> References: <1280343653-26380-1-git-send-email-fenghua.yu@intel.com> <1280343653-26380-3-git-send-email-fenghua.yu@intel.com> Content-Type: text/plain; charset="UTF-8" Organization: Ericsson Date: Wed, 28 Jul 2010 12:25:47 -0700 Message-ID: <1280345147.1830.57.camel@groeck-laptop> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2314 Lines: 59 On Wed, 2010-07-28 at 15:00 -0400, Fenghua Yu wrote: > From: Fenghua Yu > > This patch adds a hwmon driver for package level thermal control. The driver > dumps package level thermal information through sysfs interface so that upper > level application (e.g. lm_sensor) can retrive the information. > > Instead of having the package level hwmon code in coretemp, I write a seperate > driver pkgtemp because: > > First, package level thermal sensors include not only sensors for each core, > but also sensors for uncore, memory controller or other components in the > package. Logically it will be clear to have a seperate hwmon driver for package > level hwmon to monitor wider range of sensors in a package. Merging package > thermal driver into core thermal driver doesn't make sense and may mislead. > > Secondly, merging the two drivers together may cause coding mess. It's easier > to include various package level sensors info if more sensor information is > implemented. Coretemp code needs to consider a lot of legacy machine cases. > Pkgtemp code only considers platform starting from Sandy Bridge. > > On a 1Sx4Cx2T Sandy Bridge platform, lm-sensors dumps the pkgtemp and coretemp: > > pkgtemp-isa-0000 > Adapter: ISA adapter > physical id 0: +33.0°C (high = +79.0°C, crit = +99.0°C) > > coretemp-isa-0000 > Adapter: ISA adapter > Core 0: +32.0°C (high = +79.0°C, crit = +99.0°C) > > coretemp-isa-0001 > Adapter: ISA adapter > Core 1: +32.0°C (high = +79.0°C, crit = +99.0°C) > > coretemp-isa-0002 > Adapter: ISA adapter > Core 2: +32.0°C (high = +79.0°C, crit = +99.0°C) > > coretemp-isa-0003 > Adapter: ISA adapter > Core 3: +32.0°C (high = +79.0°C, crit = +99.0°C) > > Signed-off-by: Fenghua Yu > Reviewed-by: Len Brown > Reviewed-by: Guenter Roeck That I provided feedback does not mean that I endorsed a "Reviewed-by" signature. It is inappropriate to add such a signature without my approval. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/